Readd non-breaking version of #119 #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #230 +/- ##
==========================================
- Coverage 87.50% 87.46% -0.04%
==========================================
Files 20 20
Lines 1880 1875 -5
==========================================
- Hits 1645 1640 -5
Misses 205 205
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sean-Der
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As i mentioned in my rollback patch (#227), i removed two backward-incompatible PRs from the main branch and i wrote that i would have contributed them again in a non-breaking version.
This is the non-breaking version of #119.
Field
Header.PayloadOffsethas been marked as deprecated in order to allow maintainers to quickly find and remove it whenever this packet gets a major version bump. It is not populated anymore.Field
Packet.Rawhas been marked as deprecated in order to allow maintainers to quickly find and remove it whenever this packet gets a major version bump. It is not populated anymore.